Re: PATCH [2.4.0test10]: Kiobuf#02, fault-in fix

Stephen C. Tweedie
2000-11-06T15:05:39Z

Hi,

On Fri, Nov 03, 2000 at 11:27:21PM +0100, Andrea Arcangeli wrote:
> On Thu, Nov 02, 2000 at 01:40:21PM +0000, Stephen C. Tweedie wrote:
> > + if (!write || pte_write(*pte))
>
> You should check pte is dirty, not only writeable.

Why?

> > - map = follow_page(ptr);
> > + map = follow_page(ptr, datain);
>
> Here you should _first_ follow_page and do handle_mm_fault _only_ if the pte is
> not ok.

Agreed --- I'll push that as a performace diff to Linus once the
essential bug-fixes are in.

Cheers,
Stephen