Re: PATCH [2.4.0test10]: Kiobuf#02, fault-in fix

Stephen C. Tweedie
2000-11-08T12:31:43Z

Hi,

On Mon, Nov 06, 2000 at 09:23:38AM -0800, Linus Torvalds wrote:

> We should just change the page followers (do_no_page() and friends) to
> return the "struct page" directly, instead of returning an "int".

Even, as Andrea pointed out, if the cost is that we have to do two
extra atomic ops to bump the page count inside do_*_page and drop
it again in the fault handler?

I'll do it, but not if we later decide that the cost isn't worth it
and have to throw the code out.

Cheers,
Stephen