From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A22EB64DC for ; Mon, 17 Jul 2023 10:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44C206B0072; Mon, 17 Jul 2023 06:25:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D6918D0002; Mon, 17 Jul 2023 06:25:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 275798D0001; Mon, 17 Jul 2023 06:25:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 151A76B0072 for ; Mon, 17 Jul 2023 06:25:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD255804A1 for ; Mon, 17 Jul 2023 10:25:50 +0000 (UTC) X-FDA: 81020722860.11.29FDFD2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 8FFE38001B for ; Mon, 17 Jul 2023 10:25:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SfykH/ii"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689589548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ZxqwFcIYi400ycUN1jF1UBiOV7Go/IiKqR9OlilEKQ=; b=Tl8xO07dMqwbyznIKrKDkgLGbjWUwDMyTSD8C+zHIqapaxqe/oSiqJsiAw4+r+1Hi21LfD azecZ9thXVhGaDJSFvqCuSFSQmb2QQlfHc3wfAAdy2EF4qktjVrpy0MNh81ULKSfv4mkHq wuqTJh6X8YC6y/lGQBcFJI9F4vj4VYM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689589548; a=rsa-sha256; cv=none; b=EFnAzZQk1NcoYkML5hA9slypr8jyli2qSPW6hpL9BoBAuqm/NxoJmz6tXfuNQRu3bj5a+O CVcyMvJRaltSt/W/jlo3PbEKqG2ulqGVAnm2QRR+aITSAod1yQ60fYUEerPSPIo7TrlYA8 e/1kvsu7I83u+4+jgHKfx4Hd95vbkp4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SfykH/ii"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689589547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ZxqwFcIYi400ycUN1jF1UBiOV7Go/IiKqR9OlilEKQ=; b=SfykH/ii3gUCTwlyPuuCth+cz001fCWo95eWHJiSUOn65rniv0I8nUqum9T2TOTs9h0f/8 YGi6pYFViNM1FtuYbUvoywXkP25N53QuE15VHpDDSb8eO792EaoINwhwjmRGMQ47lVVkCQ c+j9coZwgS0ZIcR7yWBv3h+UhR4T6rg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-tIBhUayRNuCsLhsV0Eh5Fg-1; Mon, 17 Jul 2023 06:25:46 -0400 X-MC-Unique: tIBhUayRNuCsLhsV0Eh5Fg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3158f4d72e9so2372136f8f.1 for ; Mon, 17 Jul 2023 03:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689589545; x=1692181545; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ZxqwFcIYi400ycUN1jF1UBiOV7Go/IiKqR9OlilEKQ=; b=AQlCuIxwhtE7aOy4Fq6TS5PXTgiUDapfuADqvCZTSiKbp5CDXgLsP48PpoLxWPajpC IONW4WOqUh/uEMvxwoJCuipxvHUzl+ZU3ngfw0GbwpPGluLWI1xBn7ubylPaagkva4vz JgLwopnhqjwcEyEfYbkV43VZVndYsiHMAWPIErImP6ngKbbgfWJR+SnUHt+R6Ta06oDC Lox8eMdtd+LpZJaDzLyo/xL2O2lDvS3mMS6/EJiHElA4RF7FUHtWxCGsAphiK7LmdCR0 RKZCKmGGb8tQwtzOEXBTN+0JAZOMfGdlwNUcwRrkm6lEKSeyqeZbfKC11fYGKTUSLUOd p+zg== X-Gm-Message-State: ABy/qLaFskckiTZfKKwEV/hV3Hl8UtZjHcDj9EoG7SG5/ClgtZ/eOxnZ Lo2UDXvS6HxPYP8WYFMKofbjoxjH/p2kHQkEPcP5oYyTf6zWKqYBFM8yQRWJdoSgoH6gPmXSa33 bMa4tRveHcmY= X-Received: by 2002:a5d:6301:0:b0:313:f548:25b9 with SMTP id i1-20020a5d6301000000b00313f54825b9mr10182303wru.40.1689589545445; Mon, 17 Jul 2023 03:25:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEWwgj2gvrTcZVcFzDTLfBjRjMXpKrSXg5bhLw4PXADJbZO+n+htRPdtsID+emCjARx8zYmVw== X-Received: by 2002:a5d:6301:0:b0:313:f548:25b9 with SMTP id i1-20020a5d6301000000b00313f54825b9mr10182288wru.40.1689589545080; Mon, 17 Jul 2023 03:25:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:400:2501:5a2e:13c6:88da? (p200300cbc735040025015a2e13c688da.dip0.t-ipconnect.de. [2003:cb:c735:400:2501:5a2e:13c6:88da]) by smtp.gmail.com with ESMTPSA id j1-20020a5d4641000000b0031434936f0dsm18732085wrs.68.2023.07.17.03.25.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 03:25:44 -0700 (PDT) Message-ID: <2000511c-d551-5b3d-a9a9-adb4ba3be1f1@redhat.com> Date: Mon, 17 Jul 2023 12:25:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/5] mm: use vma_is_stack() and vma_is_heap() To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-3-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230712143831.120701-3-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: uuf65cuxhyxioxd3i5b8mcryr6c73cn5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8FFE38001B X-Rspam-User: X-HE-Tag: 1689589548-817025 X-HE-Meta: U2FsdGVkX1+74BqnITGHcu7DAbtZo8vnURDfh5fSAeOpqel4baL9TOC+QGIeXy88Isa05WHQCxWzYdTAkIJIG1Isjcdcw/rqtVYeqj+4JdKJkHKxcUguMPt+82od3qt/GLF6DR/VUE45M762JoeOL3jP/lF8trrLoZS/aeJLAGLSz4/f110TW1v/PGwy1nAIHU7HfUCSM6cKXti9eoUNm3dhkl8t/Sjj3B5+XNij7+pzfO86pFP4eqqgDbxAjBE8VY+VYfGfSNlVxNez65lydsgOQXlHSaSgopp4sV8J8XKqedLzHQawwtELXV/uARHZACck77Dpc1heQshimSaCNBIEpLNDNzUn0CEFN138sAzRXtBrQF9jfND7vVtoRYWqANWiVpjKmCuu7xQmJoN4jNmYgkYrS39+mPhGNmqKvkR+EqXDEOsw6KZIhq1YB9/m/oIK+DyEpSnm26BfHosVC5okqEw4RE/w/fjSWyfHAv7bZdQtUFwkBuN0A0NU994/3zdCYXOHIuBeQhuIoUaoA8uP/8GaWQYn3EEiNcLQmoIWd2wSfWer8aB679JHAqTe72H9NYpcRaw+k4DgQSQXFrZJqUFU69zdD8+NCzIVHXAN/bQ4+F6WhmaKXN6AoQWcKG7DMgE9niZhK41jF8fMgN9/kHkByFyZ4BiSkm6gj97F8VC+j9owhD5waUIidaD+S2K9+AOAPGisHpk2WxZbRFXJD8TvFTeExdaaSbvjUZ5cjid4z//zd0P61BAVDGAKrYLXTPgrbQB9dVP+IsU37IXE1jh1nwlyCKPnKvkw941tyEQ7yB7C6N+w7+wjaWRNSrFaHxLAvyXde1bhy0lHVGZkuxc7NiFwMQWNi3KHyYW++fvnR63CDpBFNK2/6W7VXVDtEYfWTT8dVeIaovoosV86NtkAuj3Z+oHyaOJCooa3KFTlVRWZ+ZvdATsRnMBEzM4GIoxyzfK7gU2ABMv yIx7oH8J DcrQPOOojXdtZgEOFIHw7LEAIVRC9PIKtKq4Q0Vu1sAYz7mv6j/EwjQjYq+Kc1eMPhcM/FmcgUSlctvuHedu5caPRrZIfYErz/b/lYMUCWtXLmd6WKqPanjBoCK99pg7Iija7JEoH05myRLhoYbsl4cyi6qJ0mOEr+pmBze7QgsCnapK411ilEZged4WyJyD6EhLbXfkSEvLCxwSahXjvpDteM65J7ILA7DV1jmp1uq39aaAHjU+NATLajC9SBhCdsrBC4t9+vzTaNjvW0NiA70UnbNE30J6PrUbq8GA8/XmBtWgAio2ffuj+BOcr48xqyP408RV4PgxfuwHoNtRuuvjgh4MN4MPNjiYN2h8Bq+gzv9o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.07.23 16:38, Kefeng Wang wrote: > Use the helpers to simplify code. > > Signed-off-by: Kefeng Wang > --- > fs/proc/task_mmu.c | 24 ++++-------------------- > fs/proc/task_nommu.c | 15 +-------------- > 2 files changed, 5 insertions(+), 34 deletions(-) > Please squash patch #1 and this patch and call it something like "mm: factor out VMA stack and heap checks" And then, maybe also keep the comments in these functions, they sound reasonable to have. -- Cheers, David / dhildenb