Re: [PATCH] struct page shrinkage

Rik van Riel
2002-02-26T02:07:51Z

On Mon, 25 Feb 2002, David S. Miller wrote:
> From: Rik van Riel <riel@conectiva.com.br>
> On Mon, 25 Feb 2002, David S. Miller wrote:
>
> > Please fix the atomic_t assumptions in init_page_count() first.
> > You should be using atomic_set(...).
>
> Why ? You'll see init_page_count() is _only_ used from
> free_area_init_core(), when nothing else is using the VM
> yet.
>
> Rik, not every architecture has a "counter" member of
> atomic_t, that is the problem. This is a hard bug, please
> fix it. It is an opaque type, accessing its' implementation
> directly is therefore illegal in the strongest way possible.

OK, agreed. I'm making a new patch right now.

regards,

Rik
--
"Linux holds advantages over the single-vendor commercial OS"
-- Microsoft's "Competing with Linux" document

http://www.surriel.com/ http://distro.conectiva.com/