Re: [PATCH] struct page shrinkage

William Lee Irwin III
2002-02-26T02:46:12Z

Rik van Riel wrote:
>>
>> + clear_bit(PG_locked, &p->flags);

On Mon, Feb 25, 2002 at 06:16:49PM -0800, Andrew Morton wrote:
> Please don't do this. Please use the macros. If they're not
> there, please create them.
>
> Bypassing the abstractions in this manner confounds people
> who are implementing global locked-page accounting.
>
> In fact, I think I'll go rename all the page flags...

This is lingering context from the driver... it's ugly, I didn't
go after cleaning that up when I had to touch this function because
of the usual minimal-impact / only do one thing principle.

Perhaps others were similarly (un)motivated.

Cheers,
Bill