Re: [PATCH] 10/4 -ac to newer rmap

Christoph Hellwig
2002-11-13T19:33:48Z

> /*
> * Wait for a page to get unlocked.
> *
> * This must be called with the caller "holding" the page,
> * ie with increased "page->count" so that the page won't
> * go away during the wait..
> - *
> - * The waiting strategy is to get on a waitqueue determined
> - * by hashing. Waiters will then collide, and the newly woken
> - * task must then determine whether it was woken for the page
> - * it really wanted, and go back to sleep on the waitqueue if
> - * that wasn't it. With the waitqueue semantics, it never leaves
> - * the waitqueue unless it calls, so the loop moves forward one
> - * iteration every time there is
> - * (1) a collision
> - * and
> - * (2) one of the colliding pages is woken
> - *
> - * This is the thundering herd problem, but it is expected to
> - * be very rare due to the few pages that are actually being
> - * waited on at any given time and the quality of the hash function.
> */

What is the pint of removing comments?