Re: Linus rollup

Andrew Morton
2003-01-29T10:25:55Z

"David S. Miller" <davem@redhat.com> wrote:
>
> From: Russell King <rmk@arm.linux.org.uk>
> Date: Wed, 29 Jan 2003 09:59:49 +0000
>
> /* This function must be called with interrupts disabled
>
> which hasn't been true for some time, and is even less true now that
> local IRQs don't get disabled. Does this matter... for UP?
>
> I disable local IRQs during gettimeofday() on sparc.
>
> These locks definitely need to be taken with IRQs disabled.
> Why isn't x86 doing that?

Darned if I know. Looks like Andrea's kernel will deadlock if
arch/i386/kernel/time.c:timer_interrupt() takes i8253_lock
while that cpu is holding the same lock in do_slow_gettimeoffset().