Re: Linus rollup

Stephen Hemminger
2003-01-30T17:37:06Z

> you certainly mean wmb() not rmb(), right? If yes, then yes.
>
> I actually didn't notice the write_begin/end, not sure who could need
> them, I would suggest removing them, rather than to revert the mb()
> there too.

The write_begin/end was suggested by Andrew as a simplification for use
when using this to update values already write-locked by other means.

One possible usage was to fix the race issues with non-atomic update
of 64 bit i_size.