Re: 2.5.67-mm2

Denis Vlasenko
2003-04-14T06:24:26Z

On 13 April 2003 17:54, Arjan van de Ven wrote:
> On Sun, 2003-04-13 at 15:12, Ingo Oeser wrote:
> > Hi Andrew,
> > hi lists readers,
> >
> > On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> > > +gfp_repeat.patch
> > >
> > > Implement __GFP_REPEAT: so we can consolidate lots of
> > > alloc-with-retry code.
> >
> > What about reworking the semantics of kmalloc()?
> >
> > Many users of kmalloc get the flags and size reversed (major
> > source of hard to find bugs), so wouldn't it be simpler to have:
>
> that in itself is easy to find btw; just give every GFP_* an extra
> __GFP_REQUIRED bit and then check inside kmalloc for that bit (MSB?)
> to be set.....

This will incur runtime penalty
--
vda