Re: 2.5.68-mm4

William Lee Irwin III
2003-05-02T13:18:57Z

On Fri, May 02, 2003 at 02:01:49AM -0700, Andrew Morton wrote:
> +dont-set-kernel-pgd-on-PAE.patch
> little ia32 optimisation/cleanup

It looks like no one listened to my commentary on the set_pgd() patch.

Remove pointless #ifdef, pointless set_pgd(), and a mysterious line
full of nothing but whitespace after the #endif, and update commentary.

-- wli

$ diffstat ../patches/mm4-2.5.68-2
fault.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)

diff -urpN mm4-2.5.68-1/arch/i386/mm/fault.c mm4-2.5.68-2/arch/i386/mm/fault.c
--- mm4-2.5.68-1/arch/i386/mm/fault.c 2003-05-02 05:32:27.000000000 -0700
+++ mm4-2.5.68-2/arch/i386/mm/fault.c 2003-05-02 05:54:14.000000000 -0700
@@ -333,16 +333,12 @@ vmalloc_fault:

if (!pgd_present(*pgd_k))
goto no_context;
+
/*
- * kernel pmd pages are shared among all processes
- * with PAE on. Since vmalloc pages are always
- * in the kernel area, this will always be a
- * waste with PAE on.
+ * set_pgd(pgd, *pgd_k); here would be useless on PAE
+ * and redundant with the set_pmd() on non-PAE.
*/
-#ifndef CONFIG_X86_PAE
- set_pgd(pgd, *pgd_k);
-#endif
-
+
pmd = pmd_offset(pgd, address);
pmd_k = pmd_offset(pgd_k, address);
if (!pmd_present(*pmd_k))