Re: 2.5.67-mm1

William Lee Irwin III
2003-04-08T14:08:11Z

On Tue, Apr 08, 2003 at 04:22:39AM -0700, Andrew Morton wrote:
> http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.67-mm1.gz
> Will appear sometime at
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm1/
> . sparc64 is now using gcc-3.x, so there is a patch here to make gcc-2.95
> the minimum required version.
> . A few rmap-speedup patches reduce the rmap CPU tax by 25-30% on a P4
> . Various other cleaups, speedups and fixups.

task_vsize() mysteriously appeared on my profiles. This should remove
it from them by using the already in-use elsewhere for rlimit checks
mm->total_vm for the benefit of O(1) cachelines touched.

--- virgin-2.5.67/fs/proc/task_mmu.c Wed Jan 15 08:46:04 2003
+++ wli-2.5.67-1/fs/proc/task_mmu.c Tue Apr 8 06:57:27 2003
@@ -45,13 +45,7 @@

unsigned long task_vsize(struct mm_struct *mm)
{
- struct vm_area_struct *vma;
- unsigned long vsize = 0;
-
- for (vma = mm->mmap; vma; vma = vma->vm_next)
- vsize += vma->vm_end - vma->vm_start;
-
- return vsize;
+ return PAGE_SIZE * mm->total_vm;
}

int task_statm(struct mm_struct *mm, int *shared, int *text,