Re: 2.5.73-mm2

William Lee Irwin III
2003-06-28T23:11:13Z

William Lee Irwin III <wli@holomorphy.com> wrote:
>> Here's highpmd.

On Sat, Jun 28, 2003 at 04:00:13PM -0700, Andrew Morton wrote:
> I taught patch-scripts a new trick:
> check_patch()
> {
> if grep "^+.*[ ]$" $P/patches/$1.patch
> then
> echo warning: $1 adds trailing whitespace
> fi
> }

William Lee Irwin III <wli@holomorphy.com> wrote:
> + if (pmd_table != pmd_offset_kernel(pgd, 0))
> + pmd = pmd_offset_kernel(pgd, address);
> +#define __pgd_page(pgd) (__bpn_to_ba(pgd_val(pgd)))

On Sat, Jun 28, 2003 at 04:00:13PM -0700, Andrew Morton wrote:
> warning: highpmd adds trailing whitespace
> You're far from the worst. There's some editor out there which
> adds trailing tabs all over the place. I edited the diff.

This is not my editor; it is either a manual screwup or cut and paste
(inside vi(1) and/or ed(1) buffers) of code which did so beforehand.

Thanks for cleaning that up for me; it's one of my own largest pet
peeves and I'm not terribly pleased to hear I've committed it (though
I'll not go so far as to shoot the messenger).

On Sat, Jun 28, 2003 at 04:00:13PM -0700, Andrew Morton wrote:
> What architectures has this been tested on?

i386 only, CONFIG_HIGHMEM64G with various combinations of highpte &
highpmd, and nohighmem. No CONFIG_HIGHMEM4G or non-i386 machines that
can run 2.5.x are within my grasp (obviously CONFIG_HIGHMEM4G machines
could, I just don't have them, and the discontig code barfs on mem=).