Re: 2.5.74-mm3

Joe Thornber
2003-07-11T08:25:32Z

On Thu, Jul 10, 2003 at 02:21:08PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 08 Jul 2003 22:35:48 PDT, Andrew Morton <akpm@osdl.org> said:
>
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.74/2.5.74-mm3/
>
> OK, I'm finally getting around to actually commenting, this has been a niggling issue for
> a while...
>
> > All 113 patches:
>
> > 64-bit-dev_t-kdev_t.patch
> > 64-bit dev_t and kdev_t
>
> Yes, this patch says "not ready for prime time, it breaks things".
>
> In particular, this gives the device-mapper userspace indigestion, because the
> ioctl passes something other than a 64-bit kdev_t in from libdevmapper. Upshot
> is that the LVM2 'vgchange -ay' fails gloriously.
>
> Workaround: Compile the devmapper/LVM stuff with a private copy of include/
> linux/kdev_t.h that matches the one the kernel uses. No, I didn't actually get
> that to work, so I backed out the 64-bit patch...
>
> (And no, the recent devmapper/LVM2 stuff posted doesn't fix this).

The v1 ioctl interface passes the dev in as a __kernel_dev_t, so
unfortunately if you change the size of __kernel_dev_t you will have
to rebuild the tools.

The v4 ioctl interface just uses a __u64 which I hope will be future
proof.

- Joe