Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix

Christoph Hellwig
2004-04-03T08:40:58Z

On Fri, Apr 02, 2004 at 10:35:14PM +0200, Andrea Arcangeli wrote:
> how can that be the second one? (I deduced it was the first one because
> it cannot be the second one and the offset didn't look at the very end
> of the function). This is the second one:
>
> if (!PageCompound(p))
> bad_page(__FUNCTION__, p);
>
> but bad_page shows p->flags == 0x00080008 and 1<<PG_compound ==
> 0x80000.
>
> So PG_compound is definitely set for "p" and it can't be the second one
> triggering.
>
> Can you double check? Maybe we should double check the asm. Something
> sounds fundamentally wrong in the asm, sounds like a miscompilation,
> which compiler are you using?

Because I didn't trust my ppc assembly reading that much I put in a printk
and it's actually the third bad_page(), sorry.