Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix

Rajesh Venkatasubramanian
2004-03-26T04:06:50Z

Hi Andrea,

I am yet to look at the new -aa you released. A small change is
required below. Currently, I cannot generate a patch. Sorry. Please
fix it by hand. Thanks.

>
> - list_for_each_entry(vma, list, shared) {
> + vma = __vma_prio_tree_first(root, &iter, h_pgoff, h_pgoff);

This should be:
vma = __vma_prio_tree_first(root, &iter, h_pgoff, ULONG_MAX);

> + while (vma) {
> unsigned long h_vm_pgoff;
[snip]
> + vma = __vma_prio_tree_next(vma, root, &iter, h_pgoff, h_pgoff);
> }

and here it should be:
vma = __vma_prio_tree_next(vma, root, &iter,
h_pgoff, ULONG_MAX);

Thanks,
Rajesh