Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix

Andrew Morton
2004-04-06T04:43:30Z

Andrea Arcangeli <andrea@suse.de> wrote:
>
> Then there's the pagebuf_associate_memory that rings
> an extremely *loud* bell, pagebuf_get_no_daddr and XBUF_SET_PTR sounds
> even more, then I go on with xlog_get_bp and tons of other things doing
> pagebuf I/O with kmalloced memory with variable size of the kmalloc. Too
> many concidences for this not being an xfs bug.

It does pagebuf I/O with kmalloced memory? Wow. Pretty much anything
which goes from kmalloc virtual addresses back to pageframes is a big fat
warning sign.

Do you see any reason why we shouldn't flip things around and make the
hugetlb code explicitly request the compound page metadata when allocating
the pages?