Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix

Nathan Scott
2004-04-07T01:33:07Z

On Tue, Apr 06, 2004 at 06:01:41PM +0200, Andrea Arcangeli wrote:
> On Tue, Apr 06, 2004 at 06:16:46AM +0100, Christoph Hellwig wrote:
> > Can you try the patch below (testing it now, but I'm pretty sure it'll fix it)
> > instead of all the kmalloc changes?:
>
> I'm having some email dealy so I don't know if you sent me more recent
> emails, did it work fine as expected or should I keep my kmalloc change?
>

Christophs away for a few days, so I'll jump in. The patch was not
quite right - the first part should be dropped, the second section
is right. In the first hunk (i.e. the pagebuf_lookup_pages changes)
we are always working with page cache pages there, so the change was
unnecessary (it also tested a flag which only gets set several lines
down in that call, so wasn't quite right anyway). The second part of
the patch is the critical piece, as it avoids updating the page->private
field in the IO completion handler for non-pagecache pages. I've been
testing with just that piece, and it looks good.

I'll be putting this into our local XFS trees shortly, and will send
it on to Linus and Andrew soon.

thanks Andrea.

--
Nathan