[PATCH] get_nodes mask miscalculation

Brent Casavant
2004-08-09T22:39:55Z

It appears there is a nodemask miscalculation in the get_nodes()
function in mm/mempolicy.c. This bug has two effects:

1. It is impossible to specify a length 1 nodemask.
2. It is impossible to specify a nodemask containing the last node.

The following patch against 2.6.8-rc3 has been confirmed to solve
both problems.

Signed-off-by: Brent Casavant <bcasavan@sgi.com>

--- linux-2.6.8-rc3/mm/mempolicy.c 2004-08-03 16:28:51.000000000 -0500
+++ linux-work/mm/mempolicy.c 2004-08-09 14:56:44.000000000 -0500
@@ -132,7 +132,6 @@
unsigned long nlongs;
unsigned long endmask;

- --maxnode;
bitmap_zero(nodes, MAX_NUMNODES);
if (maxnode == 0 || !nmask)
return 0;

--
Brent Casavant bcasavan@sgi.com Forget bright-eyed and
Operating System Engineer http://www.sgi.com/ bushy-tailed; I'm red-
Silicon Graphics, Inc. 44.8562N 93.1355W 860F eyed and bushy-haired.