Re: [PATCH] Avoid unecessary zone spinlocking on refill_inactive_zone()

Marcelo Tosatti
2004-08-28T12:35:30Z

On Sat, Aug 28, 2004 at 03:14:23PM +1000, Nick Piggin wrote:
> Marcelo Tosatti wrote:
>
> >On a side note, the current accounting of inactive/active pages is broken
> >in refill_inactive_zone (due to pages being freed in __release_pages).
> >I plan to fix that tomorrow - should be easy as returning the number of
> >pages
> >freed in __release_pages and take that into account.
> >
>
> Hi,
> I don't think this is a problem: release_pages should do del_page_from_lru,
> which would take care of accounting, wouldn't it?
>
> Maybe I'm not looking in the right place.

Oh no, you are right, del_page_from_lru() will do the accounting.

Sorry for the noise.