Re: follow_page()

Nick Piggin
2004-11-11T12:20:15Z

Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>Kill it..?
>
>
> Think so. We'd need to review all callers to make sure that they really
> are marking pages dirty after modifying them. Right now someone may just
> be feeling lucky.
>
> (looks at access_process_vm, wonders why it isn't doing flush_dcache_page).
>

Is it because copy_{to,from}_user_page already does flushing?
Looks like it... sorry, I'm not quite up to speed on this so
I'll stop talking crap for now :)

I think you're definitely right about your original concern
though, and the callers should be all checked.