From: Andi Kleen <ak@suse.de>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andi Kleen <ak@suse.de>, Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [RFC] Possible alternate 4 level pagetables?
Date: Sun, 14 Nov 2004 09:25:25 +0100 [thread overview]
Message-ID: <20041114082525.GB16795@wotan.suse.de> (raw)
In-Reply-To: <4196F12D.20005@yahoo.com.au>
On Sun, Nov 14, 2004 at 04:46:21PM +1100, Nick Piggin wrote:
> Just looking at your 4 level page tables patch, I wondered why the extra
> level isn't inserted between pgd and pmd, as that would appear to be the
> least intrusive (conceptually, in the generic code). Also it maybe matches
> more closely the way that the 2->3 level conversion was done.
I did it the way I did to keep i386 and other archs obviously correct
because their logic doesn't change at all for the three lower levels,
and the highest level just hands a pointer through.
Regarding intrusiveness in common code: you pretty much have to change
most of of mm/memory.c, no matter what you do. Also there are overall
only 7 or 8 users that really need the full scale changes, so
it's not as bad as it looks. Ok there is ioremap in each architecture,
but usually you can cheat for these because you know the architecture
will never support 4levels.
I'm sorry, but I don't see much advantage of your patches over mine.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-14 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 5:46 [RFC] Possible alternate 4 level pagetables? Nick Piggin
2004-11-14 5:46 ` Nick Piggin
2004-11-14 5:47 ` Nick Piggin
2004-11-14 5:48 ` Nick Piggin
2004-11-14 5:50 ` Nick Piggin
2004-11-14 8:25 ` Andi Kleen [this message]
2004-11-15 1:19 ` Nick Piggin
2004-11-15 21:37 ` Hugh Dickins
2004-11-16 1:11 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041114082525.GB16795@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox