Re: [PATCH] prevent NULL mmap in topdown model

Linus Torvalds
2005-05-19T02:47:57Z

On Wed, 18 May 2005, Rik van Riel wrote:
>
> On Wed, 18 May 2005, Linus Torvalds wrote:
>
> > Why not just change the "addr >= len" test into "addr > len" and be done
> > with it?
>
> If you're fine with not catching dereferences of a struct
> member further than PAGE_SIZE into a struct when the struct
> pointer is NULL, sure ...

I'm certainly ok with that, especially since it should never be a problem
in practice (ie the virtual memory map getting so full that we even get to
these low allocations should be basically something that never happens
under normal load).

However, it would be good to have even the trivial patch tested.
Especially since what it tries to fix is a total corner-case in the first
place..

Linus