Re: [RFC 1/3] non-resident page tracking

Rik van Riel
2005-08-08T20:30:17Z

On Mon, 8 Aug 2005, David S. Miller wrote:

> > @@ -359,7 +362,10 @@ struct page *read_swap_cache_async(swp_e

> > - lru_cache_add_active(new_page);
> > + if (activate >= 0)
> > + lru_cache_add_active(new_page);
> > + else
> > + lru_cache_add(new_page);
>
> This change is totally unrelated to the rest of the
> patch, and is not mentioned in the changelog. Could
> you explain it?

Oops, you're right. This is part of the replacement policy in
CLOCK-Pro, ARC, CART, etc. and should have been in a separate
patch.

This is what I get for pulling an all-nighter. ;)

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan