Re: [PATCH 07/07] i386: numa emulation on pc

Dave Hansen
2005-10-03T16:16:44Z

On Mon, 2005-10-03 at 18:59 +0900, Magnus Damm wrote:
> > > +#ifdef CONFIG_NUMA_EMU
> > > + bootmap_size = init_bootmem(max(min_low_pfn, node_start_pfn[0]),
> > > + min(max_low_pfn, node_end_pfn[0]));
> > > +#else
> > > bootmap_size = init_bootmem(min_low_pfn, max_low_pfn);
> > > +#endif
> >
> > This shouldn't be necessary. Again, take a look at my discontig
> > separation patches and see if what I did works for you here.
>
> Do you mean "discontig-consolidate0.patch"? Maybe I'm misunderstanding.

This one, I believe:

http://sr71.net/patches/2.6.14/2.6.14-rc2-git8-mhp1/broken-out/B2.1-i386-discontig-consolidation.patch

> > > +#ifdef CONFIG_NUMA_EMU
> > ...
> > > +#endif
> >
> > Ewwwwww :) No real need to put new function in a big #ifdef like that.
> > Can you just create a new file for NUMA emulation?
>
> Hehe, what is this, a beauty contest? =) I agree, but I guess the
> reason for this code to be here is that a similar arrangement is done
> by x86_64...

If that's really the case, can they _actually_ share code? Maybe we can
do this NUMA emulation thing in non-arch code. Just guessing...

> I will create a new file. Is arch/i386/mm/numa_emu.c good?

> But first, you have written lots and lots of patches, and I am
> confused. Could you please tell me on which patches I should base my
> code to make things as easy as possible?

This is the staging ground for my memory hotplug work. But, it contains
all of my work on other stuff, too. If you build on top of this, it
would be great:

http://sr71.net/patches/2.6.14/2.6.14-rc2-git8-mhp1/

-- Dave