Re: [PATCH 1/2] Page migration via Swap V2: Page Eviction

Andrew Morton
2005-10-18T01:04:51Z

Christoph Lameter <clameter@sgi.com> wrote:
>
> + write_lock_irq(&mapping->tree_lock);
> +
> + if (page_count(page) != 2 || PageDirty(page)) {
> + write_unlock_irq(&mapping->tree_lock);
> + goto retry_later_locked;
> + }

This needs the (uncommented (grr)) smp_rmb() copied-and-pasted as well.

It's a shame about the copy-and-pasting :( Is it unavoidable?