Re: [PATCH 5/8] Direct Migration V2: upgrade MPOL_MF_MOVE and sys_migrate_pages()

KAMEZAWA Hiroyuki
2005-11-09T01:35:34Z

Christoph Lameter wrote:
> + err = migrate_pages(pagelist, &newlist, &moved, &failed);
> +
> + putback_lru_pages(&moved); /* Call release pages instead ?? */
> +
> + if (err >= 0 && list_empty(&newlist) && !list_empty(pagelist))
> + goto redo;

Here, list_empty(&newlist) is needed ?
For checking permanent failure case, list_empty(&failed) looks better.

-- Kame