Re: [RFC][PATCH 2/8] Create emergency trigger

Matthew Dobson
2005-11-21T05:51:27Z

Paul Jackson wrote:
>>@@ -876,6 +879,16 @@ __alloc_pages(gfp_t gfp_mask, unsigned i
>> int can_try_harder;
>> int did_some_progress;
>>
>>+ if (is_emergency_alloc(gfp_mask)) {
>
>
> Can this check for is_emergency_alloc be moved lower in __alloc_pages?
>
> I don't see any reason why most __alloc_pages() calls, that succeed
> easily in the first loop over the zonelist, have to make this check.
> This would save one conditional test and jump on the most heavily
> used code path in __alloc_pages().

Good point, Paul. Will make sure that gets moved.

Thanks!