Re: [PATCH 6/9] clockpro-clockpro.patch

Rik van Riel
2005-12-31T01:22:12Z

On Fri, 30 Dec 2005, Marcelo Tosatti wrote:

> I think that final objective should be to abstract it away completly,
> making it possible to select between different policies, allowing
> further experimentation and implementations such as energy efficient
> algorithms.

I'm not convinced. That might just make vmscan.c harder to read ;)

> About CLOCK-Pro itself, I think that a small document with a short
> introduction would be very useful...

http://linux-mm.org/AdvancedPageReplacement

> > The HandCold rotation is driven by page reclaim needs. HandCold in turn
> > drives HandHot, for every page HandCold promotes to hot HandHot needs to
> > degrade one hot page to cold.
>
> Why do you use only two clock hands and not three (HandHot, HandCold and
> HandTest) as in the original paper?

Because the non-resident pages cannot be in the clock.
This is both because of space overhead, and because the
non-resident list cannot be per zone.

I agree though, Peter's patch could use a lot more
documentation.

--
All Rights Reversed