From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 8 Jan 2006 13:43:27 -0800 From: Andrew Morton Subject: Re: [patch 1/4] mm: page refcount use atomic primitives Message-Id: <20060108134327.63c3afeb.akpm@osdl.org> In-Reply-To: <43C178D5.5010703@yahoo.com.au> References: <20060108052307.2996.39444.sendpatchset@didi.local0.net> <20060108052342.2996.33981.sendpatchset@didi.local0.net> <20060107215413.560aa3a9.akpm@osdl.org> <43C178D5.5010703@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Nick Piggin wrote: > > > That's from a two-minute-peek. I haven't thought about this dreadfully > > hard. But I'd like to gain some confidence that you have, please. This > > stuff is tricky. > > > > Right, no blam. This is how I avoid taking the LRU lock. > > "Instead, use atomic_inc_not_zero to ensure we never **pick up a 0 refcount** > page from the LRU (ie. we guarantee the page will not be touched)." > > I don't understand what you're asking? Well if you don't understand me, how do you expect me to? Ho hum. Please redo the patches into something which vaguely applies and let's give them a spin. I would prefer that the BUG_ONs be split into a separate patch tho. Or at least, let's take a real close look at whether they're really needed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org