Re: [patch] hugepage allocator cleanup

William Lee Irwin III
2006-01-25T15:05:13Z

On Wed, Jan 25, 2006 at 10:11:03AM +0100, Nick Piggin wrote:
> This is a slight rework of the mechanism for allocating "fresh" hugepages.
> Comments?
> --
> Insert "fresh" huge pages into the hugepage allocator by the same
> means as they are freed back into it. This reduces code size and
> allows enqueue_huge_page to be inlined into the hugepage free
> fastpath.
> Eliminate occurances of hugepages on the free list with non-zero
> refcount. This can allow stricter refcount checks in future. Also
> required for lockless pagecache.

I don't really see any particular benefit to the rearrangement for
hugetlb's own sake. Explaining more about how it it's needed for the
lockless pagecache might help.