From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: clameter@engr.sgi.com, marcelo.tosatti@cyclades.com, linux-mm@kvack.org
Subject: Re: Get rid of scan_control
Date: Sat, 11 Feb 2006 21:14:37 -0800 [thread overview]
Message-ID: <20060211211437.0633dfdb.akpm@osdl.org> (raw)
In-Reply-To: <43EEC136.5060609@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> There are downsides to it. I was basically on the fence with its
> removal from mainline, because the complexity of parameters going
> to/from functions make the improvement borderline.
>
> But I would have kept it for my internal work, and given Marcelo
> is also interested in it I guess it could stay for now (unless
> you trump that with some performance numbers I guess).
I'm wobbly too. I still hate the thing, but I hate it less after I fixed
up some of its straggliness.
Returning nr_reclaimed up and down the stack makes sense too - I'll try that.
btw, it'd be nice to think of some better function names too. We have:
try_to_free_pages
->shrink_caches
->shrink_zone
->shrink_cache
->shrink_list
which is fairly irrational.
Something like
try_to_free_pages
->shrink_zones(struct zone **zones, ..)
->shrink_zone(struct zone *, ...)
->do_shrink_zone(struct zone *, ...)
->shrink_page_list(struct list_head *, ...)
perhaps. Maybe s/shrink/reclaim/ just to confuse everyone more.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-12 5:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 5:02 Get rid of scan_control Christoph Lameter
2006-02-11 4:53 ` Marcelo Tosatti
2006-02-11 9:32 ` Andrew Morton
2006-02-11 9:46 ` Andrew Morton
2006-02-12 3:33 ` Nick Piggin
2006-02-12 3:47 ` Christoph Lameter
2006-02-12 4:08 ` Nick Piggin
2006-02-12 4:41 ` Christoph Lameter
2006-02-12 5:01 ` Nick Piggin
2006-02-12 5:14 ` Andrew Morton [this message]
2006-02-12 5:37 ` Andrew Morton
2006-02-12 6:49 ` Christoph Lameter
2006-02-12 7:53 ` Andrew Morton
2006-02-13 17:54 ` Christoph Lameter
2006-02-12 6:25 ` Christoph Lameter
2006-02-11 19:01 ` Christoph Lameter
2006-02-11 21:13 ` Andrew Morton
2006-02-11 21:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060211211437.0633dfdb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox