From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 1/5] mm: remap_vmalloc_range
Date: Fri, 21 Apr 2006 00:17:12 -0700 [thread overview]
Message-ID: <20060421001712.4cd5625e.akpm@osdl.org> (raw)
In-Reply-To: <20060301045910.12434.4844.sendpatchset@linux.site>
Nick Piggin <npiggin@suse.de> wrote:
>
> Add a remap_vmalloc_range and get rid of as many remap_pfn_range and
> vm_insert_page loops as possible.
>
> remap_vmalloc_range can do a whole lot of nice range checking even
> if the caller gets it wrong (which it looks like one or two do).
>
>
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page + vma->vm_pgoff,
> - PAGE_SIZE, vma->vm_page_prot))
> - if (remap_pfn_range(vma, addr, pfn, PAGE_SIZE, PAGE_READONLY))
You've removed the ability for the caller to set the pte protections - it
now always uses vma->vm_page_prot.
please explain...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-04-21 7:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 6:43 [patch 0/5] mm: improve remapping of vmalloc regions Nick Piggin
2006-04-21 6:43 ` [patch 1/5] mm: remap_vmalloc_range Nick Piggin
2006-04-21 7:17 ` Andrew Morton [this message]
2006-04-21 7:33 ` Nick Piggin
2006-04-21 7:59 ` Andrew Morton
2006-04-21 8:06 ` Nick Piggin
2006-04-21 7:29 ` Andrew Morton
2006-04-21 7:41 ` Nick Piggin
2006-04-21 7:43 ` Nick Piggin
2006-04-21 8:02 ` Andrew Morton
2006-04-21 6:43 ` [patch 2/5] mm: remove vmalloc_to_pfn Nick Piggin
2006-04-21 6:55 ` Nick Piggin
2006-04-21 6:43 ` [patch 3/5] mm: remove rvmalloc Nick Piggin
2006-04-21 6:43 ` [patch 4/5] mm: extra remap_vmalloc_range check Nick Piggin
2006-04-21 6:44 ` [patch 5/5] drivers: leave vm_flags alone Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2006-04-20 17:06 [patch 0/5] mm: improve remapping of vmalloc regions Nick Piggin
2006-04-20 17:06 ` [patch 1/5] mm: remap_vmalloc_range Nick Piggin
2006-04-20 17:22 ` Christoph Hellwig
2006-04-20 17:33 ` Nick Piggin
2006-04-20 18:09 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421001712.4cd5625e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).