From: Christoph Lameter <clameter@sgi.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, Hugh Dickins <hugh@veritas.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Christoph Lameter <clameter@sgi.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH 2/7] page migration: Remove unnecessarily exported functions
Date: Thu, 27 Apr 2006 23:03:07 -0700 (PDT) [thread overview]
Message-ID: <20060428060307.30257.8191.sendpatchset@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060428060302.30257.76871.sendpatchset@schroedinger.engr.sgi.com>
page migration: Remove unnecessarily exported functions
Remove the export for migrate_page_remove_references() and
migrate_page_copy() that are unlikely to be used directly by
filesystems implementing migration. The export was useful
when buffer_migrate_page() lived in fs/buffer.c but it has now
been moved to migrate.c in the migration reorg.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.17-rc2-mm1/mm/migrate.c
===================================================================
--- linux-2.6.17-rc2-mm1.orig/mm/migrate.c 2006-04-27 19:28:57.347549552 -0700
+++ linux-2.6.17-rc2-mm1/mm/migrate.c 2006-04-27 19:34:41.194349304 -0700
@@ -250,7 +250,7 @@
* the page can be blocked. Establish the new page
* with the basic settings to be able to stop accesses to the page.
*/
-int migrate_page_remove_references(struct page *newpage,
+static int migrate_page_remove_references(struct page *newpage,
struct page *page, int nr_refs)
{
struct address_space *mapping = page_mapping(page);
@@ -343,12 +343,11 @@
return 0;
}
-EXPORT_SYMBOL(migrate_page_remove_references);
/*
* Copy the page to its new location
*/
-void migrate_page_copy(struct page *newpage, struct page *page)
+static void migrate_page_copy(struct page *newpage, struct page *page)
{
copy_highpage(newpage, page);
@@ -385,7 +384,6 @@
if (PageWriteback(newpage))
end_page_writeback(newpage);
}
-EXPORT_SYMBOL(migrate_page_copy);
/************************************************************
* Migration functions
Index: linux-2.6.17-rc2-mm1/include/linux/migrate.h
===================================================================
--- linux-2.6.17-rc2-mm1.orig/include/linux/migrate.h 2006-04-18 20:00:49.000000000 -0700
+++ linux-2.6.17-rc2-mm1/include/linux/migrate.h 2006-04-27 19:35:10.943477554 -0700
@@ -8,8 +8,6 @@
extern int isolate_lru_page(struct page *p, struct list_head *pagelist);
extern int putback_lru_pages(struct list_head *l);
extern int migrate_page(struct page *, struct page *);
-extern void migrate_page_copy(struct page *, struct page *);
-extern int migrate_page_remove_references(struct page *, struct page *, int);
extern int migrate_pages(struct list_head *l, struct list_head *t,
struct list_head *moved, struct list_head *failed);
extern int migrate_pages_to(struct list_head *pagelist,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-04-28 6:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 6:03 [PATCH 1/7] page migration: Reorder functions in migrate.c Christoph Lameter
2006-04-28 6:03 ` Christoph Lameter [this message]
2006-04-28 6:03 ` [PATCH 3/7] page migration: Change handling of address spaces Christoph Lameter
2006-04-28 6:03 ` [PATCH 4/7] page migration: Drop nr_refs parameter Christoph Lameter
2006-04-28 7:30 ` KAMEZAWA Hiroyuki
2006-04-28 13:57 ` Christoph Lameter
2006-04-28 6:03 ` [PATCH 5/7] page migration: synchronize from and to lists Christoph Lameter
2006-04-28 7:46 ` KAMEZAWA Hiroyuki
2006-04-28 15:31 ` Christoph Lameter
2006-04-29 0:27 ` KAMEZAWA Hiroyuki
2006-04-29 0:33 ` Christoph Lameter
2006-04-29 0:44 ` KAMEZAWA Hiroyuki
2006-04-29 0:46 ` Christoph Lameter
2006-04-28 6:03 ` [PATCH 6/7] page migration: Extract try_to_unmap Christoph Lameter
2006-04-28 6:03 ` [PATCH 7/7] page migration: Add new fallback function Christoph Lameter
2006-04-28 6:42 ` Christoph Lameter
2006-04-28 22:08 ` [PATCH 1/7] page migration: Reorder functions in migrate.c Andrew Morton
2006-04-28 23:01 ` Christoph Lameter
2006-04-28 23:18 ` Andrew Morton
2006-04-29 0:14 ` Christoph Lameter
2006-04-29 0:36 ` Andrew Morton
2006-04-29 0:46 ` Christoph Lameter
2006-04-29 2:27 ` Andrew Morton
2006-04-29 2:48 ` Christoph Lameter
2006-04-29 0:54 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428060307.30257.8191.sendpatchset@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).