From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 28 Apr 2006 20:23:43 -0700 (PDT) From: Christoph Lameter Message-Id: <20060429032343.4999.33245.sendpatchset@schroedinger.engr.sgi.com> In-Reply-To: <20060429032246.4999.21714.sendpatchset@schroedinger.engr.sgi.com> References: <20060429032246.4999.21714.sendpatchset@schroedinger.engr.sgi.com> Subject: {PATCH 1/2} More PM: do not inc/dec rss counters Sender: owner-linux-mm@kvack.org Return-Path: To: akpm@osdl.org Cc: linux-mm@kvack.org, Hugh Dickins , Lee Schermerhorn , Christoph Lameter , KAMEZAWA Hiroyuki List-ID: more page migration: Do not dec/inc rss counters If we install a migration entry then the rss not really decreases since the page is just moved somewhere else. We can save ourselves the work of decrementing and later incrementing which will just eventually cause cacheline bouncing. Signed-off-by: Christoph Lameter Index: linux-2.6.17-rc3/mm/migrate.c =================================================================== --- linux-2.6.17-rc3.orig/mm/migrate.c 2006-04-28 19:33:55.335332017 -0700 +++ linux-2.6.17-rc3/mm/migrate.c 2006-04-28 19:37:31.941975877 -0700 @@ -165,7 +165,6 @@ if (!is_migration_entry(entry) || migration_entry_to_page(entry) != old) goto out; - inc_mm_counter(mm, anon_rss); get_page(new); pte = pte_mkold(mk_pte(new, vma->vm_page_prot)); if (is_write_migration_entry(entry)) Index: linux-2.6.17-rc3/mm/rmap.c =================================================================== --- linux-2.6.17-rc3.orig/mm/rmap.c 2006-04-28 19:22:56.064823992 -0700 +++ linux-2.6.17-rc3/mm/rmap.c 2006-04-28 19:37:31.941975877 -0700 @@ -595,6 +595,7 @@ list_add(&mm->mmlist, &init_mm.mmlist); spin_unlock(&mmlist_lock); } + dec_mm_counter(mm, anon_rss); } else { /* * Store the pfn of the page in a special migration @@ -606,7 +607,6 @@ } set_pte_at(mm, address, pte, swp_entry_to_pte(entry)); BUG_ON(pte_file(*pte)); - dec_mm_counter(mm, anon_rss); } else dec_mm_counter(mm, file_rss); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org