Re: [PATCH 01/14] Per zone counter functionality

Peter Zijlstra
2006-06-09T09:22:13Z

On Thu, 2006-06-08 at 21:00 -0700, Andrew Morton wrote:
> On Thu, 8 Jun 2006 16:02:44 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:

> > +#ifdef CONFIG_SMP
> > +void refresh_cpu_vm_stats(int);
> > +void refresh_vm_stats(void);
> > +#else
> > +static inline void refresh_cpu_vm_stats(int cpu) { };
> > +static inline void refresh_vm_stats(void) { };
> > +#endif
>
> do {} while (0), please. Always. All other forms (afaik) have problems.
> In this case,
>
> if (something)
> refresh_vm_stats();
> else
> foo();
>
> will not compile.

It surely will, 'static inline' does not make it less of a function.
Although the trailing ; is not needed in the function definition.