Re: [PATCH 01/14] Per zone counter functionality

Andrew Morton
2006-06-09T17:38:20Z

On Fri, 9 Jun 2006 10:18:23 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

> On Fri, 9 Jun 2006, Andrew Morton wrote:
>
> > There's no need for an atomic op - at the most the architecture would need
> > local_irq_disable() protection, and that's only if it doesn't have an
> > atomic-wrt-this-cpu add instruction.
>
> So I can drop the VM_STATS() definitions?

I _think_ so. But a bit of a review of the existing atomic ops for the
major architectures wouldn't hurt.

> > > Right thought about that one as well. Can we stablize this first before I
> > > do another big reorg?
> >
> > That's unfortunate patch ordering. Do it (much) later I guess.
>
> Well there are a couple of trailing issues that would have to be resolved
> before that happens. I have another patchset here that does something more
> to the remaining counters.

It's a relatively minor issue - we can do this little cleanup much later on.