Re: [PATCH 1/6] mm: tracking shared dirty pages

Andrew Morton
2006-06-22T06:15:00Z

On Wed, 21 Jun 2006 23:07:37 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

> On Wed, 21 Jun 2006, Andrew Morton wrote:
>
> > Performance testing is critical here. I think some was done, but I don't
> > reall what tests were performed, nor do I remember the results. Without such
> > info it's not possible to make a go/no-go decision.
>
> Tests did show that there was no performance regression for the usual
> tests. That is to be expected since the patch should only modify the
> behavior of shared writable mapping. The use of those is rare in typical
> benchmarks.

Of course. In this case one should prepare an artificial microbenchmark so
we can understand the worst case.