Re: [RFC][PATCH] mm: fixup do_wp_page()

Hugh Dickins
2006-06-28T18:20:10Z

On Wed, 28 Jun 2006, Peter Zijlstra wrote:
>
> How about something like this? This should make all anonymous write
> faults do as before the page_mkwrite patch.

Yes, I believe your patch below is just how it should be.

> As for copy_one_pte(), I'm not sure what you meant, shared writable
> anonymous pages need not be write protected as far as I can see.

Anonymous pages in a shared writable vma, got there via ptrace poke.
They're in a curious limbo between private and shared. You can
reasonably argue that the page was supposed to be shared in the first
place, so although it's now become private, it's reasonable for it to
remain shared at least between parent and child. I don't disagree.

But if it's then swapped out under memory pressure, and brought back
in, it will be treated as an ordinary anonymous page, write-protected,
and once parent or child makes a modification, will cease to be shared
between parent and child. Not a big deal to lose sleep over, but
such pages do behave inconsistently.

Hugh

> --- linux-2.6-dirty.orig/mm/memory.c 2006-06-28 13:16:15.000000000 +0200
> +++ linux-2.6-dirty/mm/memory.c 2006-06-28 16:18:51.000000000 +0200
> @@ -1466,11 +1466,21 @@ static int do_wp_page(struct mm_struct *
> goto gotten;
>
> /*
> - * Only catch write-faults on shared writable pages, read-only
> - * shared pages can get COWed by get_user_pages(.write=1, .force=1).
> + * Take out anonymous pages first, anonymous shared vmas are
> + * not accountable.
> */
> - if (unlikely((vma->vm_flags & (VM_WRITE|VM_SHARED)) ==
> + if (PageAnon(old_page)) {
> + if (!TestSetPageLocked(old_page)) {
> + reuse = can_share_swap_page(old_page);
> + unlock(old_page);
> + }
> + } else if (unlikely((vma->vm_flags & (VM_WRITE|VM_SHARED)) ==
> (VM_WRITE|VM_SHARED))) {
> + /*
> + * Only catch write-faults on shared writable pages,
> + * read-only shared pages can get COWed by
> + * get_user_pages(.write=1, .force=1).
> + */
> if (vma->vm_ops && vma->vm_ops->page_mkwrite) {
> /*
> * Notify the address space that the page is about to
> @@ -1502,9 +1512,6 @@ static int do_wp_page(struct mm_struct *
> dirty_page = old_page;
> get_page(dirty_page);
> reuse = 1;
> - } else if (PageAnon(old_page) && !TestSetPageLocked(old_page)) {
> - reuse = can_share_swap_page(old_page);
> - unlock_page(old_page);
> }
>
> if (reuse) {