Re: Profiling: Require buffer allocation on the correct node

Christoph Lameter
2006-08-10T04:53:44Z

On Thu, 10 Aug 2006, Andi Kleen wrote:

> On Thursday 10 August 2006 04:18, Christoph Lameter wrote:
> > Profiling really suffers with off node buffers. Fail if no memory is available
> > on the nodes. The profiling code can deal with these failures should
> > they occur.
>
> At least for Opterons and other small NUMAs I have my doubts this is a good strategy.
> However it probably shouldn't happen very often, but if it happened it would be
> the wrong thing.
>
> In general shouldn't there be a printk at least? Doing such things silently is a bit
> nasty.

The code already checks for failing allocations and it gives a messages
AFAIK. This is just a fix so that the allocator does what they thought it
would be doing.