Re: [PATCH 1/1] network memory allocator.

Andi Kleen
2006-08-15T08:08:23Z

Andrew Morton <akpm@osdl.org> writes:
>
> There will be heaps of cacheline pingpong accessing these arrays. I'd have
> though that
>
> static struct whatever {
> avl_t avl_node_id;
> struct avl_node **avl_node_array;
> struct list_head *avl_container_array;
> struct avl_node *avl_root;
> struct avl_free_list *avl_free_list_head;
> spinlock_t avl_free_lock;
> } __cacheline_aligned_in_smp whatevers[NR_CPUS];
>
> would be better.

Or even better per cpu data. New global/static NR_CPUS arrays should be really discouraged.

-Andi