Re: [patch 1/2] own header file for struct page.

Roman Zippel
2006-09-09T21:05:33Z

Hi,

On Fri, 8 Sep 2006, Heiko Carstens wrote:

> In order to get of all these problems caused by macros it seems to
> be a good idea to get rid of them and convert them to static inline
> functions. Because of header file include order it's necessary to have a
> seperate header file for the struct page definition.
>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> Patches are against git tree as of today. Better ideas welcome of course.
>
> include/linux/mm.h | 64 --------------------------------------------
> include/linux/page.h | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 75 insertions(+), 63 deletions(-)

To avoid the explosion in number of small header files each containing a
single definition, it would be better to generally split between the
definitions and implementations, so IMO mm_types.h with all the structures
and defines from mm.h would be better.

bye, Roman