Re: [patch 3/3] mm: fault handler to replace nopage and populate

Thomas Hellstrom
2006-10-10T08:39:48Z

Benjamin Herrenschmidt wrote:
>>Still, even with NOPAGE_REFAULT or the equivalent with the new fault() code,
>>in the case we need to take this route, (and it looks like we won't have
>>to),
>>I guess we still need to restart from find_vma() in the fault()/nopage()
>>handler to make sure the VMA is still present. The object mutex need to
>>be dropped as well to avoid deadlocks. Sounds complicated.
>
>
> But as we said, it should be enough to do the flag change with the
> object mutex held as long as it's after unmap_mapped_ranges()
>
> Ben.
>
>
Agreed.
/Thomas