Re: [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers

Arjan van de Ven
2006-10-10T15:07:56Z

On Tue, 2006-10-10 at 15:33 +0100, Christoph Hellwig wrote:
> On Tue, Oct 10, 2006 at 04:21:32PM +0200, Nick Piggin wrote:
> > This patchset is against 2.6.19-rc1-mm1 up to
> > numa-add-zone_to_nid-function-swap_prefetch.patch (ie. no readahead stuff,
> > which causes big rejects and would be much easier to fix in readahead
> > patches than here). Other than this feature, the -mm specific stuff is
> > pretty simple (mainly straightforward filesystem conversions).
> >
> > Changes since last round:
> > - trimmed the cc list, no big changes since last time.
> > - fix the few buglets preventing it from actually booting
> > - reinstate filemap_nopage and filemap_populate, because they're exported
> > symbols even though no longer used in the tree. Schedule for removal.
>
> Just kill them and the whole ->populate methods. We have a better API that
> replaces them 100% with your patch, and they've never been a widespread
> API.

concur; just nuke the parts that have become unused right away. They're
not "removed" as such, but "replaced by better"