Re: [PATCH 3/3] hugetlb: fix absurd HugePages_Rsvd

Adam Litke
2006-10-25T21:31:34Z

On Wed, 2006-10-25 at 16:26 +1000, David Gibson wrote:
> Correct these by moving the i_size check to before the allocation of a
> new page.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

I have some early patches which do this very same thing albeit for a
different reason. I was looking to create a proper ->nopage() operation
for hugetlbfs and quarantine fs things (inodes included) to
fs/hugetlbfs/inode.c. The added advantage is hugetlb_[get/put]_quota()
calls could also be isolated to fs/hugetlbfs/inode.c. Unfortunately
this was all held up by Nick Piggin's awesome ->fault() work. Speaking
of which, could we just use VM_FAULT_RETRY semantics to handle the
i_size check that patch in the parent email removes? [ Obviously not
for 2.6.19 :-) ]

--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center