From: Nick Piggin <npiggin@suse.de>
To: Neil Brown <neilb@suse.de>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc][patch] mm: half-fix page tail zeroing on write problem
Date: Fri, 2 Feb 2007 08:21:33 +0100 [thread overview]
Message-ID: <20070202072133.GA26431@wotan.suse.de> (raw)
In-Reply-To: <17858.55858.642522.861130@notabene.brown>
On Fri, Feb 02, 2007 at 05:29:06PM +1100, Neil Brown wrote:
> On Friday February 2, npiggin@suse.de wrote:
> > Hi,
> >
> > For no important reason, I've again looked at those zeroing patches that
> > Neil did a while back. I've always thought that a simple
> > `write(fd, NULL, size)` would cause the same sorts of problems.
>
> Yeh, but who in their right mind would do that???
> Oh, you did :-)
Well that's the test-case. Obviously not many people do it, but that's
all the more reason to be careful about correct behaviour.
> I cannot see why you make a change to fault_in_pages_writeable. Is it
> just for symmetry?
Yes.
> For the rest, it certainly makes sense to return an early -EFAULT if
> you cannot fault in the page.
I think so.
Thanks,
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-02-02 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 5:51 [rfc][patch] mm: half-fix page tail zeroing on write problem Nick Piggin
2007-02-02 6:29 ` Neil Brown
2007-02-02 7:21 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202072133.GA26431@wotan.suse.de \
--to=npiggin@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).