From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Feb 2007 00:54:41 -0800 From: Andrew Morton Subject: Re: [RFC][PATCH][0/4] Memory controller (RSS Control) Message-Id: <20070219005441.7fa0eccc.akpm@linux-foundation.org> In-Reply-To: <20070219065019.3626.33947.sendpatchset@balbir-laptop> References: <20070219065019.3626.33947.sendpatchset@balbir-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Balbir Singh Cc: linux-kernel@vger.kernel.org, vatsa@in.ibm.com, ckrm-tech@lists.sourceforge.net, xemul@sw.ru, linux-mm@kvack.org, menage@google.com, svaidy@linux.vnet.ibm.com, devel@openvz.org List-ID: On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh wrote: > This patch applies on top of Paul Menage's container patches (V7) posted at > > http://lkml.org/lkml/2007/2/12/88 > > It implements a controller within the containers framework for limiting > memory usage (RSS usage). It's good to see someone building on someone else's work for once, rather than everyone going off in different directions. It makes one hope that we might actually achieve something at last. The key part of this patchset is the reclaim algorithm: > @@ -636,6 +642,15 @@ static unsigned long isolate_lru_pages(u > > list_del(&page->lru); > target = src; > + /* > + * For containers, do not scan the page unless it > + * belongs to the container we are reclaiming for > + */ > + if (container && !page_in_container(page, zone, container)) { > + scan--; > + goto done; > + } Alas, I fear this might have quite bad worst-case behaviour. One small container which is under constant memory pressure will churn the system-wide LRUs like mad, and will consume rather a lot of system time. So it's a point at which container A can deleteriously affect things which are running in other containers, which is exactly what we're supposed to not do. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org