Re: [rfc][patch 1/2] mm: rework isolate_lru_page

Christoph Lameter
2007-03-05T17:47:16Z

On Mon, 5 Mar 2007, Nick Piggin wrote:

> isolate_lru_page logically belongs to be in vmscan.c than migrate.c.

Good idea.

> + * Isolate one page from the LRU lists. Must be called with an elevated
> + * refcount on the page, which is how it differs from isolate_lru_pages
> + * (which is called without a stable reference).
> + *
> + * lru_lock must not be held, interrupts must be enabled.
> + *
> + * Returns:
> + * -EBUSY: page not on LRU list
> + * 0: page removed from LRU list and added to the specified list.

The new version of isolate_lru_page no longer adds the page to a list.
Remove that portion.