Re: [patch] rfc: introduce /dev/hugetlb

Mel Gorman
2007-03-23T15:15:55Z

On Fri, 23 Mar 2007, William Lee Irwin III wrote:

> On Fri, 23 Mar 2007, Ken Chen wrote:
>>> -#ifdef HAVE_ARCH_HUGETLB_UNMAPPED_AREA
>>> -unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long
>>> addr,
>>> - unsigned long len, unsigned long pgoff, unsigned long flags);
>>> -#else
>>> -static unsigned long
>>> +unsigned long
>>> hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
>>> unsigned long len, unsigned long pgoff, unsigned long flags)
>>
> On Fri, Mar 23, 2007 at 03:03:57PM +0000, Mel Gorman wrote:
>> What is going on here? Why do arches not get to specify a
>> get_unmapped_area any more?
>
> Lack of compiletesting beyond x86-64 in all probability.
>

Ok, this will go kablamo on Power then even if it compiles. I don't
consider it a fundamental problem though. For the purposes of an RFC, it's
grand and something that can be worked with.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab