Re: [patch 1/3] slob: rework freelist handling

Matt Mackall
2007-05-23T21:14:20Z

On Wed, May 23, 2007 at 01:16:06PM -0700, Christoph Lameter wrote:
> Oh. And I forgot to check mm.
>
> See swap_prefetch.c:prefetch_suitable

Doesn't look problematic to me. Or if it is, it'll die for any system
that happens to use get_free_page a lot.

> I do not think the updating of these counters is optional. Their use will
> increase as we get more sophisticated in balancing the VM load. We cannot
> have developers do an #ifdef CONFIG_SLOB around ZVC use.

How does the VM deal with balancing users of get_free_page?

We can probably add a couple lines to dummy up NR_SLAB_UNRECLAIMABLE, but I
think the claim that SLOB is "broken" without it is completely overblown.

--
Mathematics is the supreme nostalgia of our time.