Re: [patch 1/3] slob: rework freelist handling

Christoph Lameter
2007-05-24T02:55:56Z

On Thu, 24 May 2007, Nick Piggin wrote:

> Sure some things may be suboptimal, but the VM cannot just fall over
> and become non-functional if there is no reclaimable slab, surely?

The check in __vm_enough_memory in particular is worrying there.
Overcommit may not work right. If large caches are created via SLOB then
we may OOM.

Of course one can dismiss this by saying that the conditions under which
this is true are rare etc etc.

Similarly the breakage of software suspend also did not matter..

Then swap prefetch (also using slab ZVCs) probably also does not matter.

Guess embedded systems just have to be careful what kernel features they
use and over time they can use less....