Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

Badari Pulavarty
2007-06-09T04:32:06Z

Andrew Morton wrote:

>On Fri, 08 Jun 2007 17:43:34 -0600
>ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>>Some user space tools need to identify SYSV shared memory when
>>examining /proc/<pid>/maps. To do so they look for a block device
>>with major zero, a dentry named SYSV<sysv key>, and having the minor of
>>the internal sysv shared memory kernel mount.
>>
>>To help these tools and to make it easier for people just browsing
>>/proc/<pid>/maps this patch modifies hugetlb sysv shared memory to
>>use the SYSV<key> dentry naming convention.
>>
>>User space tools will still have to be aware that hugetlb sysv
>>shared memory lives on a different internal kernel mount and so
>>has a different block device minor number from the rest of sysv
>>shared memory.
>>
>
>I assume this fix is preferred over Badari's? If so, why?
>
No. You still need my patch to fix the current breakage.

This patch makes hugetlbfs also use same naming convention as regular
shmem for its
name. This is not absolutely needed, its a nice to have. Currently, user
space tools
can't depend on the filename alone, since its not unique (based on kry).

Thanks,
Badari