From: Pavel Machek <pavel@ucw.cz>
To: Shani Moideen <shani.moideen@wipro.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@lists.osdl.org
Subject: Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/mm/init.c
Date: Wed, 13 Jun 2007 19:47:27 +0000 [thread overview]
Message-ID: <20070613194726.GB8273@ucw.cz> (raw)
In-Reply-To: <1181618174.2282.16.camel@shani-win>
On Tue 2007-06-12 08:46:14, Shani Moideen wrote:
> Hi,
> Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/mm/init.c.
>
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
>
>
> diff --git a/arch/i386/mm/init.c b/arch/i386/mm/init.c
> index ae43688..7dc3d46 100644
> --- a/arch/i386/mm/init.c
> +++ b/arch/i386/mm/init.c
> @@ -397,7 +397,7 @@ char __nosavedata swsusp_pg_dir[PAGE_SIZE]
>
> static inline void save_pg_dir(void)
> {
> - memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE);
> + copy_page(swsusp_pg_dir, swapper_pg_dir);
> }
> #else
> static inline void save_pg_dir(void)
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-06-13 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 3:16 [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/mm/init.c Shani Moideen
2007-06-13 19:47 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613194726.GB8273@ucw.cz \
--to=pavel@ucw.cz \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shani.moideen@wipro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox