Re: [patch 1/3] NUMA: introduce node_memory_map

Nishanth Aravamudan
2007-06-12T21:43:57Z

On 12.06.2007 [14:39:21 -0700], Christoph Lameter wrote:
>
> > Indeed, I did and (I like to think) I helped write the patches :)
>
> The patches contain your signoff because of your authorship...
>
> > We can keep
> >
> > node_set_memory()
> > node_clear_memory()
> >
> > but change node_memory() to node_has_memory() ?
>
> Hmmm.... That deviates from how the other node_xxx() things are so it
> disturbed my sense of order. We have no three word node_is/has_xxx
> yet.

Yeah, I realize that -- but I also agree with David that

node_memory()

is not intuitive at all. And we've already admitted that a few of the
macros in there are inconsistent already :)

Thanks,
Nish

--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center