Re: [patch 1/3] NUMA: introduce node_memory_map

David Rientjes
2007-06-12T21:03:07Z

On Tue, 12 Jun 2007, clameter@sgi.com wrote:

> Index: linux-2.6.22-rc4-mm2/include/linux/nodemask.h
> ===================================================================
> --- linux-2.6.22-rc4-mm2.orig/include/linux/nodemask.h 2007-06-12 12:32:38.000000000 -0700
> +++ linux-2.6.22-rc4-mm2/include/linux/nodemask.h 2007-06-12 13:45:44.000000000 -0700
> @@ -64,12 +64,16 @@
> *
> * int node_online(node) Is some node online?
> * int node_possible(node) Is some node possible?
> + * int node_memory(node) Does a node have memory?
> *

This name doesn't make sense; wouldn't node_has_memory() be better?

> * int any_online_node(mask) First online node in mask
> *
> * node_set_online(node) set bit 'node' in node_online_map
> * node_set_offline(node) clear bit 'node' in node_online_map
> *
> + * node_set_memory(node) set bit 'node' in node_memory_map
> + * node_clear_memoryd(node) clear bit 'node' in node_memory_map
> + *

Extra 'd' there in node_clear_memory().