Re: [patch 2/3] Fix GFP_THISNODE behavior for memoryless nodes

Christoph Lameter
2007-06-12T21:25:47Z

On Tue, 12 Jun 2007, David Rientjes wrote:

> That's the point. Isn't !node_memory(nid) unlikely?

Correct.

Use unlikely

Signed-off-cy: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.22-rc4-mm2/include/linux/gfp.h
===================================================================
--- linux-2.6.22-rc4-mm2.orig/include/linux/gfp.h 2007-06-12 14:22:57.000000000 -0700
+++ linux-2.6.22-rc4-mm2/include/linux/gfp.h 2007-06-12 14:24:46.000000000 -0700
@@ -179,7 +179,7 @@ static inline struct page *alloc_pages_n
* Check for the special case that GFP_THISNODE is used on a
* memoryless node
*/
- if ((gfp_mask & __GFP_THISNODE) && !node_memory(nid))
+ if (unlikely((gfp_mask & __GFP_THISNODE) && !node_memory(nid)))
return NULL;

return __alloc_pages(gfp_mask, order,