Re: [patch 1/3] NUMA: introduce node_memory_map

Christoph Lameter
2007-06-12T21:27:54Z

On Tue, 12 Jun 2007, David Rientjes wrote:

> On Tue, 12 Jun 2007, Christoph Lameter wrote:
>
> > On Tue, 12 Jun 2007, David Rientjes wrote:
> >
> > > > * int node_online(node) Is some node online?
> > > > * int node_possible(node) Is some node possible?
> > > > + * int node_memory(node) Does a node have memory?
> > > > *
> > >
> > > This name doesn't make sense; wouldn't node_has_memory() be better?
> >
> > node_set_has_memory and node_clear_has_memory sounds a bit strange.
> >
>
> This will probably be one of those things that people see in the source
> and have to look up everytime. node_has_memory() is straight-forward and
> to the point.

But node_possible is similar to node_memory.

Would you also prefer node_is_possible over node_possible?

node_is_online?