Re: [patch 1/3] NUMA: introduce node_memory_map

Nishanth Aravamudan
2007-06-12T22:32:13Z

On 12.06.2007 [15:26:25 -0700], Christoph Lameter wrote:
> On Tue, 12 Jun 2007, Nishanth Aravamudan wrote:
>
> > is not intuitive at all. And we've already admitted that a few of the
> > macros in there are inconsistent already :)
>
> I do not want to add another inconsistency.
>
> if (node_memory(node))
>
> is pretty clear as far as I can tell.

Fair enough.

> Some of the macros in include/linux/nodemask.h are inconsistent. How
> can we make those consistent. Could you come up with a consistent
> naming scheme? Add the explanation for that scheme.

I'll think it over :)

> But that should be a separate patch. And the patch would have to
> change all uses of those macros in the kernel source tree.

Agreed, will be a down-the-road thing. In the meantime, I'm rebasing the
hugetlb pool patch and sysfs interface patch on top of your stack and
will repost.

Thanks,
Nish

--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center