Re: [RFC][PATCH] hugetlbfs read support

Badari Pulavarty
2007-07-10T18:38:41Z

Christoph Hellwig wrote:

>On Mon, Jul 09, 2007 at 12:28:11PM -0700, Badari Pulavarty wrote:
>
>>Comments/flames ?
>>
>>Thanks,
>>Badari
>>
>>Support for reading from hugetlbfs files. libhugetlbfs lets application
>>text/data to be placed in large pages. When we do that, oprofile doesn't
>>work - since it tries to read from it.
>>
>>This code is very similar to what do_generic_mapping_read() does, but
>>I can't use it since it has PAGE_CACHE_SIZE assumptions. Christoph
>>Lamater's cleanup to pagecache would hopefully give me all of this.
>>
>
>The code looks fine, but I really hate that we need it all all. We really
>should make the general VM/FS code large page aware and get rid of this
>whole hack called hugetlbfs..
>
I would love to see *atleast* generic filemap handler routines does not
assume PAGE_SIZE.
Clameter's cleanup patches hopefully would all of that for us - but I am
not sure how it handles
largepages with kmap() to copy out the data.

But getting rid of hugetlbfs completely, needs bigger effort :(

Thanks,
Badari