Re: [PATCH] hugetlbfs read() support

Andrew Morton
2007-07-19T16:58:50Z

On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty <pbadari@us.ibm.com> wrote:

> > > + }
> > > +
> > > + offset += ret;
> > > + retval += ret;
> > > + len -= ret;
> > > + index += offset >> HPAGE_SHIFT;
> > > + offset &= ~HPAGE_MASK;
> > > +
> > > + page_cache_release(page);
> > > + if (ret == nr && len)
> > > + continue;
> > > + goto out;
> > > + }
> > > +out:
> > > + return retval;
> > > +}
> >
> > This code doesn't have all the ghastly tricks which we deploy to handle
> > concurrent truncate.
>
> Do I need to ? Baaahh!! I don't want to deal with them.

Nick, can you think of any serious consequences of a read/truncate race in
there? I can't..

> All I want is a simple read() to get my oprofile working.
> Please advise.

Did you consider changing oprofile userspace to read the executable with
mmap?