From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 24 Jul 2007 17:53:32 -0700 From: Andrew Morton Subject: Re: Slab API: Remove useless ctor parameter and reorder parameters Message-Id: <20070724175332.41ade708.akpm@linux-foundation.org> In-Reply-To: References: <20070724165914.a5945763.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org, Pekka Enberg List-ID: On Tue, 24 Jul 2007 17:35:53 -0700 (PDT) Christoph Lameter wrote: > On Tue, 24 Jul 2007, Andrew Morton wrote: > > > arch/i386/mm/pgtable.c:197: error: conflicting types for 'pmd_ctor' > > include/asm/pgtable.h:43: error: previous declaration of 'pmd_ctor' was here > > Ahh. External declaration of pmd_ctor missed in .h. Patch follows. > > Now is the 100% worst time to merge this sort of thing btw: I get to carry > > it for two months while the world churns. Around the -rc7 timeframe would > > be better. > > We just got rid of the destructor parameter of kmem_cache_create. Yeah, but that got merged into mainline. It's too late to merge this one. > It would > be consistent to also get rid of the useless flag in the ctor at the > same time. Honest, it's easier for everyone if we shelve this until late -rc's. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org