Re: [PATCH] Document Linux Memory Policy - V2

Randy Dunlap
2007-07-27T19:21:59Z

On Fri, 27 Jul 2007 15:01:28 -0400 Lee Schermerhorn wrote:

> On Fri, 2007-07-27 at 11:38 -0700, Randy Dunlap wrote:
> > On Fri, 27 Jul 2007 14:00:59 -0400 Lee Schermerhorn wrote:
> >
> > > [PATCH] Document Linux Memory Policy - V2
> > >
> > > Documentation/vm/memory_policy.txt | 278 +++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 278 insertions(+)
> > >
> > > Index: Linux/Documentation/vm/memory_policy.txt
> > > ===================================================================
> > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> > > +++ Linux/Documentation/vm/memory_policy.txt 2007-07-27 13:40:45.000000000 -0400
> > > @@ -0,0 +1,278 @@
> > > +
> >
> > ...
> >
> > > +
> > > +MEMORY POLICY CONCEPTS
> > > +
> > > +Scope of Memory Policies
> > > +
> > > +The Linux kernel supports four more or less distinct scopes of memory policy:
> > > +
> > > + System Default Policy: this policy is "hard coded" into the kernel. It
> > > + is the policy that governs the all page allocations that aren't controlled
> >
> > drop ^ "the"
> >
> > > + by one of the more specific policy scopes discussed below.
> >
> > Are these policies listed in order of "less specific scope to more
> > specific scope"?
>
> Randy:
>
> Thanks for the quick review. I will make the edits you suggest and
> re-post after the weekend [hoping for more feedback...].

Sure.

> To answer your question, yes, it was my intent to order them from least
> specific [or most general?] to most specific. Shall I say so?

Yes. I would.

> Other than these items, does the document make sense? Do you think it's
> worth adding? Andi was concerned about having documentation in too many
> places [code + doc].

Yes, I think that it's worth adding and makes sense, although
Christoph's comment about documenting effects instead of internal
workings also makes sense to me. That would also tend to mitigate
Andi's concern a bit.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***