Re: [patch][rfc] remove ZERO_PAGE?

J. Bruce Fields
2007-08-02T04:37:02Z

On Tue, Jul 31, 2007 at 11:19:00PM -0300, Luiz Fernando N. Capitulino wrote:
> On 7/31/07, J. Bruce Fields <bfields@fieldses.org> wrote:
> > On Wed, Aug 01, 2007 at 03:47:39AM +0200, Nick Piggin wrote:
> > > On Mon, Jul 30, 2007 at 06:39:12PM -0400, J. Bruce Fields wrote:
> > > > It looks to me like it's oopsing at the deference of
> > > > fhp->fh_export->ex_uuid in encode_fsid(), which is exactly the case
> > > > commit b41eeef14d claims to fix. Looks like that's been in since
> > > > v2.6.22-rc1; what kernel is this?
> > >
> > > Any progress with this? I'm fairly sure ZERO_PAGE removal wouldn't
> > > have triggered it.
> >
> > I agree that it's most likely an nfsd bug. I'll take another look, but
> > it probably won't be till tommorow afternoon.
>
> Bruce, is there a way to reproduce the bug b41eeef14d claims to fix?

OK, sorry, it's taking me a little time to figure out what's going on.

But fh_verify() was responsible for checking and filling in the fhp that
is wrong here, and I don't see the safeguards in fh_verify() (or in the
export-lookup process) that would ensure that the export associated with
a filehandle has a non-NULL ex_uuid whenever the filehandle has a uuid
fsid type. But I can't create a test case yet.

--b.